javascript - is using a dependency inside a object's prototype method bad? -


i'm trying create simple app retrieves youtube song data database, , have displayed on list.

here's track object looks basically:

function track(title, artist, genre, length, videoid) {   this.title = title;   this.artist = artist;   this.genre = genre;   this.length = length;   this.videoid = videoid; } 

note: videoid unique character string used player.

now, create module public api handles youtube player functionality. below:

var player = (function() {    function playvideo(videoid) {     youtubeplayer.playvid(videoid);   }    // ... other player functionality ...    return {     playvideo: function(videoid) {        return playvideo(videoid);     }   }  })(); 

(i'm making youtube's api above, forget actual code play video is, it's similar)

now, want add function track object play track. i'll calling method when user clicks play button track. below:

track.prototype.playvideo = function(player) {   player.playvideo(this.videoid); } 

basically, i'm passing in 'player' module created prototype method, , using play specific track's video using api.

is okay do, or considered bad practice? essentially, it's creating dependency on outside module inside prototype property.

if bad practice, better way approach issue?

thanks insight :)


Comments

Popular posts from this blog

ruby on rails - RuntimeError: Circular dependency detected while autoloading constant - ActiveAdmin.register Role -

c++ - OpenMP unpredictable overhead -

javascript - Wordpress slider, not displayed 100% width -